add oci pull to images #175

mac641 · 2025-11-14T14:27:49Z

Description

References

TODO

how are oci credentials supposed to be retrieved?
add tests

mac641 · 2025-11-14T14:31:21Z

@majst01 okay, so this is what I came up with. Can you do a review, pls?

Besides, I'm wondering if it's suitable to retrieve the oci credentials from env vars. Can you help me out here?

majst01 · 2025-11-15T07:19:56Z

@majst01 okay, so this is what I came up with. Can you do a review, pls?

Besides, I'm wondering if it's suitable to retrieve the oci credentials from env vars. Can you help me out here?

The OCI creadentials should be passed as optional fields from the pixiecore to the metal-hammer:

https://github.com/metal-stack/metal-hammer/blob/master/cmd/pixie-client.go#L14

Ideally a slice of registryconfig which contains the registry url, the username and the password should come from pixiecore.

mac641 · 2025-11-19T10:41:24Z

@majst01 does this work? https://github.com/metal-stack/metal-hammer/pull/175/files#diff-cfcd5a78ad9476ee24d7680dd023e71136f329c771d76ae6837ba68320b6379cR37

what does machine.Allocation.Image.URL contain? Is it the full oci url or just the image name, e.g. debian:12?

majst01 · 2025-11-20T06:50:45Z

@majst01 does this work? https://github.com/metal-stack/metal-hammer/pull/175/files#diff-cfcd5a78ad9476ee24d7680dd023e71136f329c771d76ae6837ba68320b6379cR37

what does machine.Allocation.Image.URL contain? Is it the full oci url or just the image name, e.g. debian:12?

It contains the full URL as configured in the image

machine.Allocation.Image.URL can be used without auth

…onal now

since it's not supported by name.ParseReference

…nd default to image

…hentication

…sions

cmd/install.go

cmd/image/image.go

go.mod

since they're considered integration tests and can't be run inside a docker container due to testcontainers-go

mac641 requested a review from a team as a code owner November 14, 2025 14:27

metal-robot bot added this to Development Nov 14, 2025

mac641 mentioned this pull request Nov 18, 2025

add oci config metal-stack/pixie#40

Open

mac641 force-pushed the oci-puller branch 3 times, most recently from 0bfe689 to 7052ccb Compare December 4, 2025 14:24

mac641 mentioned this pull request Dec 11, 2025

add oci push metal-stack/metal-images#375

Open

mac641 added 8 commits January 15, 2026 11:42

feat(image): add OciPull based on the example from #169

510fd03

refactor: use OciConfig in order to retrieve credentials

643508a

chore: run go mod tidy

167460c

refactor: add logging to image and format install.go

6971d38

fix: fix issue where RegistryURL was mandatory even though

dbf4f83

machine.Allocation.Image.URL can be used without auth

chore: apply latest pixie changes where OciConfig.RegistryURL is opti…

24abb10

…onal now

fix(image): remove optional oci:// prefix before parsing image reference

3573d87

since it's not supported by name.ParseReference

fix(install): add missing check if no OciConfigs have been provided a…

e330b67

…nd default to image

mac641 force-pushed the oci-puller branch 7 times, most recently from ad2bb15 to 2506148 Compare January 16, 2026 11:51

fix: fix untar destination of oci images and various typos

d5b0104

mac641 force-pushed the oci-puller branch from 2506148 to d5b0104 Compare January 16, 2026 12:34

mac641 added 2 commits January 19, 2026 16:58

test: add tests to image's oci-puller

526b28e

test(image): implement test for oci image pull from registry with aut…

6518c0b

…hentication

mac641 added 2 commits January 22, 2026 13:31

refactor(image): remove external dependency from ghcr in tests

f3d6604

fix(image): remove dependency for running tests with superuser permis…

30a8225

…sions

mac641 force-pushed the oci-puller branch 8 times, most recently from 2a95918 to b244121 Compare January 22, 2026 15:46